-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Complex Sounding Layout Example #3161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition, @kylejgillett! Just a few things to clean up and I love that the example uses so many of the sounding calculations and of course the layout structure is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. @dcamron any other feedback?
Hey guys, I just check out this example under the dev release and it is showing up kinda wonky. https://unidata.github.io/MetPy/dev/examples/Complex-Sounding-Plot.html I think this may be due to the use of the these lines:
A few of them need to be removed. Should a fix this with a new commit? |
Yes, apologies for not catching that on the initial review.
While were at it, let’s add Advanced to the beginning of the example title.
And, the sigtor and supercell composite give back a list value, so you’ll want to call `signor[0].m` and `super_comp[0].m` to future proof the example due to the way Numpy will handle passing those to the `int()` function.
When I make on the docs on my machine, the figure seems to be still not quite right (portions of the left and bottom of the figure are cut off and I can’t seem to figure out what might be causing that.
So, go ahead and put in a new PR and I’ll be sure to create the docs locally for review and ensure the final image is appearing as desired.
…--
Kevin Goebbert, Ph.D.
Professor of Meteorology
Kallay-Christopher Hall, 201-F
1809 Chapel Drive Valparaiso, IN 46383
(219) 464-5517
fax: (219) 548-7738
https://kevingoebbert.youcanbook.me/
On Sep 15, 2023 at 3:04 PM -0500, Kyle J Gillett ***@***.***>, wrote:
Hey guys,
I just check out this example under the dev release and it is showing up kinda wonky.
https://unidata.github.io/MetPy/dev/examples/Complex-Sounding-Plot.html
I think this may be due to the use of the these lines:
###########################################
A few of them need to be removed. Should a fix this with a new commit?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Hey @kgoebber, I may have recreated the plotting issue you found. Is this what you saw? I could only recreate this when using Could it be some sort of issue with the How would you feel about just including the |
Interesting. I don't think we want to introduce a |
@kylejgillett are you planning on pushing a new PR to make the corrections? If not, just let me know and I can do that. |
Hey @kgoebber, I created a new pull request with the updated code. |
Description Of Changes
Adds a more advanced Skew-T layout example to
examples\
. Closes issue #2460. Uses the existingAdvanced_Sounding.py
example to build into a more complex plot. The same imports needed for the aforementioned existing example are used in this new example. Some simple adjustments and additions, mostly through Matplotlib manipulation, help improve the readability and complexity of the base MetPy functionality.This example produces this plot from MetPy test data:
Checklist