Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout updates #3170

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Checkout updates #3170

merged 3 commits into from
Aug 30, 2023

Conversation

dopplershift
Copy link
Member

Description Of Changes

  • Remove redundant specification of default fetch-depth
  • Eliminate manual fetching of tags since actions/checkout v3.6.0 now has fetch-tags as an option

The default is already 1.
With actions/checkout#579 merged, there's now a built-in option to get
the tags within the fetch range, so no need to do it manually.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Maintenance Updates and clean ups (but not wrong) labels Aug 28, 2023
@dopplershift dopplershift requested a review from a team as a code owner August 28, 2023 22:04
@dopplershift dopplershift requested review from dcamron and removed request for a team August 28, 2023 22:04
dcamron
dcamron previously approved these changes Aug 28, 2023
@dcamron dcamron enabled auto-merge August 28, 2023 22:08
@dopplershift
Copy link
Member Author

Good news: The version in the tests is MetPy-1.5.1.post100+g48f9a8f so I think we're good.

Bad news: That version indicates we're 100 commits past the last version. Our current fetch depth? 100. I'm pretty sure this is about to "break" in CI, so we're going to get version "MetPy-Unknown" or something. Wondering if we should update to 150.

This gives us more "commit runway" so that an appropriate tag is
fetched.
@dcamron dcamron merged commit c7124e6 into Unidata:main Aug 30, 2023
23 checks passed
@github-actions github-actions bot added this to the September 2023 milestone Aug 30, 2023
@dopplershift dopplershift deleted the checkout-updates branch August 30, 2023 18:58
@dopplershift dopplershift removed this from the September 2023 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants