Add planned maintenance #194

stveit · 2024-03-24T05:30:04Z

Fixes #61, API still missing (tracked by #101). That will be separate PR

github-actions · 2024-03-24T05:31:03Z

Test results

3 files 3 suites 51s ⏱️
380 tests 380 ✅ 0 💤 0 ❌
1 140 runs 1 138 ✅ 2 💤 0 ❌

Results for commit db797f8.

♻️ This comment has been updated with latest results.

codecov · 2024-03-24T05:53:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (5b7f5c0) to head (db797f8).
Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   98.98%   98.99%   +0.01%     
==========================================
  Files          50       50              
  Lines        6565     6740     +175     
==========================================
+ Hits         6498     6672     +174     
- Misses         67       68       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/zino/planned_maintenance.py

johannaengland · 2024-03-28T15:26:15Z

I just checked in Zino1.0 and found that get_started_planned_maintenances will actually not check if the pms have ended before the current time. I think this might be something to discuss, even though it is quite an edge case, since we don't think any pms will have started after the last run, but ended before the time the function is called.

stveit · 2024-04-02T07:28:00Z

I just checked in Zino1.0 and found that get_started_planned_maintenances will actually not check if the pms have ended before the current time. I think this might be something to discuss, even though it is quite an edge case, since we don't think any pms will have started after the last run, but ended before the time the function is called.

yeah noticed this too, seems like an oversight but I guess no planned maintenance has ever been shorter than whatever interval the PM stuff runs at

johannaengland · 2024-04-02T07:36:16Z

I just checked in Zino1.0 and found that get_started_planned_maintenances will actually not check if the pms have ended before the current time. I think this might be something to discuss, even though it is quite an edge case, since we don't think any pms will have started after the last run, but ended before the time the function is called.

yeah noticed this too, seems like an oversight but I guess no planned maintenance has ever been shorter than whatever interval the PM stuff runs at

Yes, that would make very little sense to have a PM shorter than one minute.
But I still think we can add that check, that makes testing easier and seems like good practice to me.

sonarcloud · 2024-04-05T09:29:32Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

stveit · 2024-04-05T14:18:06Z

#207

lunkwill42

I don't know the original PM code intimately, so I'm just going by intuition on some of the functionality.

All in all, pretty comprehensive and nearly complete, but I'm left with a feeling that perhaps more of the functionality of the PlannedMaintenances class could be moved to the PlannedMaintenance class, especially much of the things that just take a single PlannedMaintenance object and doesn't really touch the internal state of the PlannedMaintenances object itself.

Another idea could be to split PlannedMaintance class could even be split into subclasses, one for each type ("portstate", "device"). The event matching or generating methods could then be subclass specific.

Maybe an IRL pow-wow would be better here :)

src/zino/zino.py

src/zino/statemodels.py

src/zino/planned_maintenance.py

stveit · 2024-05-30T08:53:17Z

#234 #202

stveit · 2024-05-30T08:59:08Z

#236

lunkwill42

This is really turning out nice!

Cannot finish without some nit-picks, though! :-)

src/zino/statemodels.py

tests/planned_maintenance_test.py

github-actions · 2024-05-31T13:59:57Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Elapsed time
✅ PYTHON	black	11	0.66s
✅ PYTHON	isort	11	0.23s
✅ PYTHON	ruff	11	0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

This is very similar to the Events model, just missing the index

This task checks regularly if any planned maintenances have started/stopped and handles affected events

Co-authored-by: Morten Brekkevold <[email protected]>

This fixes obvious renames and typos from code review. Co-authored-by: Johanna England <[email protected]>

The original event object is not modified externally. We need to fetch the updated copy from the event registry. Co-authored-by: Johanna England <[email protected]>

sonarcloud · 2024-06-13T07:26:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

stveit force-pushed the feature/planned-maintenance branch from e617895 to ca0a568 Compare March 24, 2024 05:46

johannaengland requested changes Mar 28, 2024

View reviewed changes

johannaengland assigned stveit Apr 2, 2024

stveit force-pushed the feature/planned-maintenance branch 2 times, most recently from bb41ab8 to c7ada43 Compare April 5, 2024 09:29

johannaengland changed the title ~~Add planned maintenace~~ Add planned maintenance Apr 5, 2024

lunkwill42 requested changes May 22, 2024

View reviewed changes

stveit force-pushed the feature/planned-maintenance branch 4 times, most recently from 3d465f7 to b980219 Compare May 29, 2024 10:15

stveit mentioned this pull request May 30, 2024

Make match_type typing more strict in planned maintenance #234

Open

stveit marked this pull request as ready for review May 30, 2024 09:30

lunkwill42 requested changes May 31, 2024

View reviewed changes

johannaengland and others added 6 commits May 31, 2024 16:22

Add PlannedMaintenance to statemodels

ee5cf6a

Add PlannedMaintenances model

6e41f9f

This is very similar to the Events model, just missing the index

Add instance of planned_maintenances to Zino state

8af0927

Add observer to zino that dumps state on changes in planned maintenances

15d869d

Add PlannedMaintenanceTask

5c9fb03

This task checks regularly if any planned maintenances have started/stopped and handles affected events

Inherit pydantic basemodel

4a4ee50

stveit and others added 23 commits June 13, 2024 09:24

Refactor dump reschedule to avoid duplicate code

e4541a4

Add test for pm change dump reschedule

448c5e6

Add pm tests

5a46e23

Rename functions

2e7d285

Fix typehint

762ab2c

Use enum for pm type

1271922

Remove todo

30ef123

Fix comment

41547d7

Use consistent error raising

612390f

Move static functions out of class to bottom of file

9111eff

Remove redunduancy in regex matching

0550b43

Check instance isntead of type string

16891bd

Use generator instead of list

3887fa5

Rename tests

0dcad36

Co-authored-by: Morten Brekkevold <[email protected]>

Expand 'get_*_maintenances' tests

8956404

Rewrite as generator

312f489

Add changelog

53e2940

Fix megalinter complaints

650d755

Apply obvious suggestions from code review

de70ce0

This fixes obvious renames and typos from code review. Co-authored-by: Johanna England <[email protected]>

Fix incorrect type annotations for fixtures

19272ec

Fix incorrect test assertion

32f3b2e

The original event object is not modified externally. We need to fetch the updated copy from the event registry. Co-authored-by: Johanna England <[email protected]>

Fix docstrings

162b46e

Only get active pms once

db797f8

stveit force-pushed the feature/planned-maintenance branch from c9df563 to db797f8 Compare June 13, 2024 07:26

stveit merged commit bbccc90 into master Jun 13, 2024
11 checks passed

stveit deleted the feature/planned-maintenance branch June 13, 2024 07:32

stveit mentioned this pull request Jun 13, 2024

Fix serializing issues in planned maintenance #253

Merged

This was referenced Jul 8, 2024

Fix incorrect timezone-naive datetimes #306

Merged

Implement the PM family of API commands #101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add planned maintenance #194

Add planned maintenance #194

stveit commented Mar 24, 2024 •

edited

Loading

github-actions bot commented Mar 24, 2024 •

edited

Loading

codecov bot commented Mar 24, 2024 •

edited

Loading

johannaengland commented Mar 28, 2024

stveit commented Apr 2, 2024

johannaengland commented Apr 2, 2024

sonarcloud bot commented Apr 5, 2024

stveit commented Apr 5, 2024

lunkwill42 left a comment •

edited

Loading

stveit commented May 30, 2024 •

edited by johannaengland

Loading

stveit commented May 30, 2024

lunkwill42 left a comment

github-actions bot commented May 31, 2024 •

edited

Loading

sonarcloud bot commented Jun 13, 2024

Add planned maintenance #194

Add planned maintenance #194

Conversation

stveit commented Mar 24, 2024 • edited Loading

github-actions bot commented Mar 24, 2024 • edited Loading

Test results

codecov bot commented Mar 24, 2024 • edited Loading

Codecov Report

johannaengland commented Mar 28, 2024

stveit commented Apr 2, 2024

johannaengland commented Apr 2, 2024

sonarcloud bot commented Apr 5, 2024

Quality Gate passed

stveit commented Apr 5, 2024

lunkwill42 left a comment • edited Loading

Choose a reason for hiding this comment

stveit commented May 30, 2024 • edited by johannaengland Loading

stveit commented May 30, 2024

lunkwill42 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 31, 2024 • edited Loading

🦙 MegaLinter status: ✅ SUCCESS

sonarcloud bot commented Jun 13, 2024

Quality Gate passed

stveit commented Mar 24, 2024 •

edited

Loading

github-actions bot commented Mar 24, 2024 •

edited

Loading

codecov bot commented Mar 24, 2024 •

edited

Loading

lunkwill42 left a comment •

edited

Loading

stveit commented May 30, 2024 •

edited by johannaengland

Loading

github-actions bot commented May 31, 2024 •

edited

Loading