Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt raise NotImplementedError from coverage #237

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lunkwill42
Copy link
Member

We just don't need it.

@lunkwill42 lunkwill42 requested a review from stveit May 31, 2024 08:39
@lunkwill42 lunkwill42 self-assigned this May 31, 2024
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Test results

  3 files    3 suites   51s ⏱️
320 tests 320 ✅ 0 💤 0 ❌
960 runs  958 ✅ 2 💤 0 ❌

Results for commit db2a9c9.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (ee3412f) to head (db2a9c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          50       50           
  Lines        6566     6566           
=======================================
  Hits         6499     6499           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lunkwill42
Copy link
Member Author

... and I don't think we need a towncrier file for this

@lunkwill42 lunkwill42 merged commit 498c77a into master Jun 3, 2024
9 of 10 checks passed
@lunkwill42 lunkwill42 deleted the coverage/ignore-uncovered-notimplementederrors branch June 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants