-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more codecov configuration to fix associating commits within PRs #251
Add more codecov configuration to fix associating commits within PRs #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me, and I assume you've tested it in another repo.
Although I feel hesitant to spend even more time on this in order to get it right, I might suggest that we maybe should look into packaging this as a reusable action (if possible), so we don't need to repeat everything over and over in all our repos.
Yes, it has been tested. It does not always show the correct number of commits, but it does show the correct coverage change due to direct and indirect changes and these can be inspected to figure out which lines have changed/missing coverage, which is what we need codecov for.
I believe that that would take more time than just copy-pasting and adapting it for our other repos. Mainly because I have no experience with packaging actions and because how we do it now consists of two steps, which I don't even know if it's possible to package these into one action. |
9dce593
to
e2b02e8
Compare
A workflow file that was very helpful for me: https://github.com/edumserrano/dotnet-sdk-extensions/blob/main/.github/workflows/upload-coverage-to-codecov.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My condolences. What $%^ to have in your brain...
This will be used for codecov configuration
This is required by codecov
e2b02e8
to
2604798
Compare
Quality Gate passedIssues Measures |
This PR does two things to hopefully get the right coverage reports for PRs from forked repos: