Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-commit hook by ruff organisation #359

Merged

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

When doing research for #358 I stumbled over this repository and realized that the ruff pre-commit hook we're using is a different one than the one made by the organisation that develops ruff. So I switched to that one.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland self-assigned this Aug 22, 2024
Copy link

sonarcloud bot commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (c0c5696) to head (482de5d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          77       77           
  Lines        9699     9699           
=======================================
  Hits         9560     9560           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely true. Charlie Marsh is the original author of Ruff, and also the founder of Astral. The ruff-pre-commit repo has been moved from his personal GitHub account to the Astral account, so the two URLs are effectively the same (the former automatically redirects to the latter) :)

@johannaengland johannaengland merged commit a0ffdb9 into Uninett:master Aug 26, 2024
9 of 10 checks passed
@johannaengland johannaengland deleted the pre-commit/use-ruff-by-own-org branch August 26, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants