Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump Zino state to temporary file and rename afterwards #366

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Aug 30, 2024

Scope and purpose

Fixes #364.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland self-assigned this Aug 30, 2024
@johannaengland johannaengland added the blocked This issue needs something else to be done before it can be resolved label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (21f7f7d) to head (f09521c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9706     9709    +3     
=======================================
+ Hits         9576     9579    +3     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I was looking for. Just nitpicking names and text, really :-)

src/zino/state.py Outdated Show resolved Hide resolved
changelog.d/364.fixed.md Outdated Show resolved Hide resolved
@johannaengland johannaengland force-pushed the bugfix/dump-to-temporary-file branch from 7e28c38 to f09521c Compare September 3, 2024 12:31
Copy link

sonarcloud bot commented Sep 3, 2024

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@lunkwill42 lunkwill42 merged commit fe2bd80 into Uninett:master Sep 3, 2024
10 checks passed
@johannaengland johannaengland deleted the bugfix/dump-to-temporary-file branch September 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue needs something else to be done before it can be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dump Zino state to temporary file and rename when successful
2 participants