Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate downtime for bgpevent #369

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Sep 4, 2024

Scope and purpose

Fixes #368 .

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

Defines when a BGPEvent is considered "down"
@stveit stveit self-assigned this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0.62s
✅ PYTHON isort 2 0 0.2s
✅ PYTHON ruff 2 0 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 4, 2024

Test results

    3 files      3 suites   1m 28s ⏱️
  594 tests   594 ✅ 0 💤 0 ❌
1 734 runs  1 732 ✅ 2 💤 0 ❌

Results for commit 1cee2be.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (949fc84) to head (1cee2be).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9709     9711    +2     
=======================================
+ Hits         9579     9581    +2     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 5, 2024

@stveit stveit marked this pull request as ready for review September 5, 2024 10:43
@stveit stveit merged commit b19d9fa into master Sep 6, 2024
10 checks passed
@stveit stveit deleted the feature/calculate-downtime-for-bgpevent branch September 6, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ac-down should be computed also for BGP events
2 participants