Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apt-get to install towncrier #373

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 16, 2024

Scope and purpose

This has become necessary due to PEP 668.

Our test workflows are safe (for now), since we test on Python versions 3.9-3.11.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
    • workflow change
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland self-assigned this Oct 16, 2024
@johannaengland johannaengland added the bug Something isn't working label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (6dc98ef) to head (7b96eb0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9711     9711           
=======================================
  Hits         9581     9581           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the workflows/fix-pip-install branch from 1d95107 to 7b96eb0 Compare October 16, 2024 12:44
@johannaengland johannaengland changed the title Fix pip install towncrier by passing break-system-packages flag Use apt-get to install towncrier Oct 16, 2024
Copy link

sonarcloud bot commented Oct 16, 2024

@lunkwill42 lunkwill42 merged commit a7d497c into Uninett:master Oct 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants