Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of garbage input to getlog #44

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jan 25, 2024

Closes #36

Sometimes, Zino 1 replies to b'getlog' with the output from b'getattrs', this leads to an exception.

That exception is here replaced with a RetryError.

@hmpf hmpf requested a review from podliashanyk January 25, 2024 07:10
@hmpf hmpf self-assigned this Jan 25, 2024
Copy link

github-actions bot commented Jan 25, 2024

Test results

    3 files      3 suites   41s ⏱️
  63 tests   63 ✔️ 0 💤 0
189 runs  189 ✔️ 0 💤 0

Results for commit d97de03.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5c9469f) 71.60% compared to head (d97de03) 71.52%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/zinolib/controllers/zino1.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   71.60%   71.52%   -0.09%     
==========================================
  Files          13       13              
  Lines        1363     1366       +3     
==========================================
+ Hits          976      977       +1     
- Misses        387      389       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but you have linting errors from flake8...

@hmpf hmpf force-pushed the fix-parse-error-in-getlog branch from 82a0995 to 5dd9180 Compare January 25, 2024 07:52
@hmpf hmpf force-pushed the fix-parse-error-in-getlog branch from 5dd9180 to d97de03 Compare January 25, 2024 11:27
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf requested a review from lunkwill42 January 25, 2024 11:29
@hmpf hmpf merged commit e00f8b9 into Uninett:main Jan 25, 2024
6 of 8 checks passed
@hmpf hmpf deleted the fix-parse-error-in-getlog branch January 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: uncaught exception in get_log_for_id/parse_response
3 participants