Add server poll #53
Merged
Add server poll #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 71.52% 71.01% -0.51%
==========================================
Files 13 13
Lines 1366 1380 +14
==========================================
+ Hits 977 980 +3
- Misses 389 400 +11 ☔ View full report in Codecov by Sentry. |
* More docs * Easier to use, hopefully * Rename "poll" to "get_event_update" since there were confusion with the other "poll" that asks the server to poll the source of a specific event for updates.
Ask the server to check for updates for a specific event.
podliashanyk
approved these changes
Mar 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code used the term
pollin two different ways:No. 1 was not implemented in the zino1 manager and got to keep its name. No. 2 was renamed to "get_event_update" (it only gets one update at a time, if any are available.)
Two bonuses: the UpdateHandler is better documented and there is now only one way to remove an event from the events list.