This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
fix: fix price impact calculation for 100% sell tax #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjkant
approved these changes
Oct 13, 2023
adjkant
approved these changes
Oct 13, 2023
| @@ -198,13 +198,21 @@ export class Trade<TInput extends Currency, TOutput extends Currency, TTradeType | |||
| return this._priceImpact | |||
| } | |||
|
|
|||
| if (this.outputTax.equalTo(ONE_HUNDRED_PERCENT)) { | |||
| throw new Error('Unable to calculate price impact for a 100% buy-tax token') | |||
There was a problem hiding this comment.
should we be throwing here? imo probably not because it makes the devx pretty rough for people using this SDK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a swap from 0 token in to 0 token out, so the price impact for the swap is 0!