VPC endpoint to unirpc #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
melodylove-uniswap
commented
Oct 19, 2024
•
melodylove-uniswap
commented
- put routing-api behind a vpc
- created a vpc endpoint to connect to unirpc vpc endpoint service in uniswap-backend account
- created route53 to point routing-dev to the vpc endpoint to avoid updating the endpoint on the service side.
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
d9bd8a0
to
5a50abc
Compare
graphite-app
bot
requested review from
xrsv,
cgkol,
jsy1218 and
a team
and removed request for
jsy1218
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (10/31/24)1 assignee was added and 5 reviewers were added to this PR based on 's automation. |
jsy1218
reviewed
Nov 1, 2024
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
996fb92
to
452fcb6
Compare
jsy1218
approved these changes
Nov 6, 2024
xrsv
reviewed
Nov 7, 2024
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
452fcb6
to
e8bc29a
Compare
|
added subnets to the vpc to get around the http port issue. |
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
6e3085f
to
4820d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.