fix(cachedRoutes): add logs for tracing #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (12/06/24)1 assignee was added and 4 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation. |
jsy1218
reviewed
Dec 6, 2024
lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts
Outdated
Show resolved
Hide resolved
jsy1218
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logs for tracing when we might be using expired cached routes in order for us to better trace and debug those occasions.
There is a fix we might do to filter those out, but adding logging first will help us debug better the source of the problem.