Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue381 #382

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Issue381 #382

merged 9 commits into from
Mar 7, 2024

Conversation

theBoEffect
Copy link
Member

@theBoEffect theBoEffect commented Mar 3, 2024

Description

This is an update that corresponds to a feature enhancement provided by the Privakey plugin. We should now be able to bind more than one user from an authgroup to a single mobile device.
The primary dependency is the Privakey latest bind API and mobile App, both of which have been launched.

Fixes # 381

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Deployment to QA and validation of the binding system is the primary test. This is pending.

  • Test A - Attempt to bind 2 users with different email addresses from a single AuthGroup. Do this as an opt-in without MFA being required.
  • Test B - Require MFA for the AuthGroup and then attempt to login using 2 different users that are not bound to a device. Ensure that both users are prompted to bind and successfully do so.

Test Configuration:

  • OS/Browser Types & Versions: Tested on a mac with chrome after deployment to K8

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README, OpenAPI/Swagger, etc.)
  • My changes generate no new warnings
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@theBoEffect
Copy link
Member Author

Failing TestB. Reviewing logs.

@theBoEffect theBoEffect merged commit de75c0a into master Mar 7, 2024
3 checks passed
@theBoEffect theBoEffect deleted the issue381 branch March 24, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant