New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some code #9

Open

l4l wants to merge 1 commit into UnitedTraders:master from l4l:refactor

l4l commented Apr 23, 2021

No semantic should be made there, if found it's an error.

Some other hints to improve the code:

split up the god-types (i.e. the ones with >5 fields), in particular testing would be much easier;
there's a lot of duplicated code, making it polymorphic might significantly reduce codebase size;
use derive_builder for builders;
use either anyhow with thiserror, or even better use snafu instead for error handling.


          Refactor some code

17106d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet