Better logs #21
Open
Better logs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsuharnikov
reviewed
Oct 22, 2024
| @@ -1,4 +1,3 @@ | |||
| package object units { | |||
| type BlockHash = BlockHash.Type | |||
| type JobResult[A] = Either[ClientError, A] | |||
There was a problem hiding this comment.
I couldn't say that I totally disagree with this decision, but wondering, why do we remove JobResult? It looks concise and hides the left part, so we haven't write it each time.
We can even rename it to Result to make it shorter and remove Job part, because it is not a "job" anymore, just a computed value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are based on #19 changes, so it's better to merge #19 first and then change base branch of this PR to main