Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE: Update macos images to latest #1931

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

stefanunity
Copy link
Collaborator

@stefanunity stefanunity commented May 21, 2024

Description

About a year ago we pinned the MacOS images for tvOS and iOS to a specific version because the new version broke our CI.
This is updating the image to the current latest.

Changes made

Update image from MacOS 12 to latest MacOS 13 (4.50.0) which are used for tvOS and iOS.
Also moved the image version into a variable in config.metadata.

Images for Mac Editor + Standalone have and will continue to use "latest".

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds value, but would be beneficial to align so that we test on similar images/versions as trunk. Have you checked this with relevant platform team(s)? It could be time consuming to test against another version and get issues not seen on trunk.

@stefanunity
Copy link
Collaborator Author

I think this adds value, but would be beneficial to align so that we test on similar images/versions as trunk. Have you checked this with relevant platform team(s)? It could be time consuming to test against another version and get issues not seen on trunk.

Trunk runs this https://images.bokken.prd.ds.unity3d.com/image/mobile/ios-macos-11-unity image for iOS + tvOS tests.

We are using an image from a different pool of images (package-ci) https://images.bokken.prd.ds.unity3d.com/image/package-ci/macos-13.

@stefanunity stefanunity merged commit 483d115 into develop Jun 3, 2024
77 of 79 checks passed
@stefanunity stefanunity deleted the update-macos-images branch June 3, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants