Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: ISXB-621 disable all action maps except default map when input system is started #1936

Closed
wants to merge 3 commits into from

Conversation

smnwttbr
Copy link
Collaborator

@smnwttbr smnwttbr commented May 27, 2024

Description

When the InputSystem MonoBehaviour is enabled, all actions maps default to enabled. Only the default action map should be enabled. ISXB-621

Changes made

TODO

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

smnwttbr added 2 commits May 27, 2024 11:10
made sure actionmaps are loaded after InputSystem.OnEnable
@smnwttbr smnwttbr requested review from ekcoh and Pauliusd01 May 27, 2024 03:15
@smnwttbr smnwttbr marked this pull request as ready for review May 27, 2024 03:38
@smnwttbr smnwttbr marked this pull request as draft May 27, 2024 03:54
@ekcoh
Copy link
Collaborator

ekcoh commented May 28, 2024

I need to dig deeper into associated repro to understand fully the problem and suggested fix.... I will return to this PR.

@Pauliusd01 Pauliusd01 requested a review from stefanunity May 31, 2024 06:06
@Pauliusd01
Copy link
Collaborator

@stefanunity hey, could you take a look at this if you have the free time? If not I can still take a look but it will take a while till I can come around to this

@Pauliusd01 Pauliusd01 closed this Jun 6, 2024
@Pauliusd01 Pauliusd01 deleted the isxb-621-disable-action-maps-when-enabled branch June 6, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants