-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: ISXB-621 input system UI input module enables referenced UI action map #1944
DOCS: ISXB-621 input system UI input module enables referenced UI action map #1944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is all good, but I wonder if this is the expected behavior. Did you compare to behavior with Input System prior to introduction of Project wide Input actions and UI for Input? If not I would recommend this is not a regression relating to the auto-enable functionality of Project-wide input actions.
I have not tested myself, however comments in the Jira ticket indicated this was not a regression. I believe this should be expected behaviour, IMO it makes sense based on how the InputSystemUIInputModule works and it's us-case. |
9bb1ca9
to
074559b
Compare
074559b
to
5ffae8a
Compare
clarified doc text about UI Input Module component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with minor amendment
…bles-referenced-action-maps
Adding @Pauliusd01 for QA assessment w.r.t. above mentioned auto-enabling |
This comment was marked as off-topic.
This comment was marked as off-topic.
I played around a bit more to see what is loaded in and when For UITK UI it goes like this: No PWA asset and UI Module exists/doesn't exist - DefaultInputActions is loaded and used For IMGUI UI the UI Module has to exist at all times for the UI to work and the PWA asset does not affect it in anyway yet it is loaded in. So I guess the new wording is correct yet the whole thing is a bit confusing still to me, mostly the reasoning behind PWA UI map being loaded in even when not needed |
…bles-referenced-action-maps
…bles-referenced-action-maps
Description
Addresses confusion when default action map is enabled, and the UI action map is also enabled via the InputSystemUIInputModule. ISXB-621
Changes made
Documentaiion added to UISupport.md
Checklist
Before review:
Changed
,Fixed
,Added
sections.([case %number%](https://issuetracker.unity3d.com/issues/...))
.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.