Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Don't install action trigger hook when notifications set to UnityEvents (case ISXB-711) #2089

Merged

Conversation

AlexTyrer
Copy link
Collaborator

@AlexTyrer AlexTyrer commented Dec 16, 2024

Description

The fix for https://jira.unity3d.com/browse/ISXB-711 (PR #2077) introduced an bug - the action trigger hooks should not be installed when the notification setting is set to use UnityEvents.

This PR addresses that defect - only install the action trigger hooks for SendMessage / BroadcastMessage and CSharp event notification types.

Testing status & QA

Local tests (SimpleDemo_UsingPlayerInput scene)
Automated tests.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

None in particular.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01 Pauliusd01 requested review from jfreire-unity and Pauliusd01 and removed request for joao-maia-u3d December 16, 2024 11:04
@AlexTyrer AlexTyrer changed the title [Input System] Don't install action trigger hook when notifications set to UnityEvents (case ISXB-711) FIX: Don't install action trigger hook when notifications set to UnityEvents (case ISXB-711) Dec 16, 2024
@jfreire-unity jfreire-unity merged commit aec5efc into develop Dec 17, 2024
79 of 83 checks passed
@jfreire-unity jfreire-unity deleted the isxb-711/fix-player-input-action-map-callback-2 branch December 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants