Bugfix: FramingTransposer with a dead zone would sometimes drift

Unity-Technologies · Dec 19, 2024 · 323516c · 323516c
1 parent 5b2d575
commit 323516c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/com.unity.cinemachine/CHANGELOG.md b/com.unity.cinemachine/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Bugfixes
 - CameraDeactivated events were not sent consistently when a blend interrupted another blend before completion.
 - CameraActivated events were not sent consistently when activation was due to timeline blends.
+- Bugfix: FramingTransposer with a dead zone would sometimes drift.
 
 
 ## [3.1.2] - 2024-10-01

diff --git a/com.unity.cinemachine/Runtime/Components/CinemachinePositionComposer.cs b/com.unity.cinemachine/Runtime/Components/CinemachinePositionComposer.cs
@@ -319,7 +319,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
                         realTargetPos - cameraOffset, hardGuideOrtho);
                 }
             }
-            curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
+            curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
             m_PreviousCameraPosition = curState.RawPosition;
 
             m_InheritingPosition = false;

diff --git a/com.unity.cinemachine/Runtime/Deprecated/CinemachineFramingTransposer.cs b/com.unity.cinemachine/Runtime/Deprecated/CinemachineFramingTransposer.cs
@@ -549,7 +549,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
                         realTargetPos - cameraOffset, hardGuideOrtho);
                 }
             }
-            curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
+            curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
             m_PreviousCameraPosition = curState.RawPosition;
 
             // Adjust lens for group framing