Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1594: missing null check in deoccluder #1001

Merged
merged 2 commits into from
May 29, 2024
Merged

CMCL-1594: missing null check in deoccluder #1001

merged 2 commits into from
May 29, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented May 27, 2024

Purpose of this PR

CMCL-1594: missing null check generated console exceptions.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

none whatsoever

@glabute glabute requested a review from AntoineCharton May 27, 2024 21:30
@glabute glabute requested a review from sebastienduverne as a code owner May 27, 2024 21:30
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 26.83%. Comparing base (d565c83) to head (be2e2ee).
Report is 1 commits behind head on main.

Files Patch % Lines
...achine/Runtime/Behaviours/CinemachineDeoccluder.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   26.83%   26.83%           
=======================================
  Files         249      249           
  Lines       27999    27999           
=======================================
  Hits         7513     7513           
  Misses      20486    20486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute merged commit cbfe9ea into main May 29, 2024
7 of 9 checks passed
@glabute glabute deleted the dev/cmcl-1594 branch May 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants