Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Group Framing works with Confiner 2D #975

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Apr 18, 2024

Purpose of this PR

GroupFraming and Confiner2D did not play well together.
Slack thread: https://unity.slack.com/archives/C4P4KJR9A/p1713367131830879

This PR introduces a special compatibility mode to handle this common use-case. GroupFraming checks for the presence of Confiner2D and if it finds one, it runs in the Body stage (with an early execution order) so that it happens before Confiner2D. Also, in this mode it monitors the ortho size and invalidates the confiner lens cache when the ortho size changes.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@glabute glabute requested a review from AntoineCharton April 18, 2024 16:30
Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Can you check why the isolation test aren't compiling?
Screenshot 2024-04-18 at 1 09 57 PM

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 27.02%. Comparing base (2b73baa) to head (77d14c4).
Report is 2 commits behind head on main.

Files Patch % Lines
...hine/Runtime/Behaviours/CinemachineGroupFraming.cs 0.00% 25 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   27.06%   27.02%   -0.04%     
==========================================
  Files         248      248              
  Lines       27856    27877      +21     
==========================================
- Hits         7540     7535       -5     
- Misses      20316    20342      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute merged commit 141cab0 into main Apr 18, 2024
9 checks passed
@glabute glabute deleted the dewv/group-framing-works-with-confiner2d branch April 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants