CMCL-0000: Group Framing works with Confiner 2D #975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
GroupFraming and Confiner2D did not play well together.
Slack thread: https://unity.slack.com/archives/C4P4KJR9A/p1713367131830879
This PR introduces a special compatibility mode to handle this common use-case. GroupFraming checks for the presence of Confiner2D and if it finds one, it runs in the Body stage (with an early execution order) so that it happens before Confiner2D. Also, in this mode it monitors the ortho size and invalidates the confiner lens cache when the ortho size changes.
Testing status
Documentation status
Technical risk
low