Update client to not require a successful ping #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to https://github.com/gdiazlo/statsd as a solution to this issue in the original repo alexcesaro#6. This will add the functionality needed while keeping the additional changes that are currently present in this fork. It is useful to have this change as the metrics within a service *shouldn't* stop a service from operating. Currently, it works as is but as soon as `.Clone` is called on the client, it crashes due to a nil conn (caused by this check).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to https://github.com/gdiazlo/statsd as a solution to this issue in the original repo alexcesaro#6.
This will add the functionality needed while keeping the additional changes that are currently present in this fork.
It is useful to have this change as the metrics within a service shouldn't stop a service from operating. Currently, it works as is but as soon as
.Cloneis called on the client, it crashes due to a nil conn (caused by this check).