Limit feature metrics #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Currently, the SDK attempts to upload metrics for every single feature that exsits on the server, regardless if they have been used or not. This results in a possibly gigantic payload, which can become too big to upload.
Closes #75
Important files
Discussion points
I'm not completely sure that this is the best way to check if a feature is being used/has been requested, but it does seem a pretty good proxy.
That
.load(Ordering::Relaxed)is very much a guess for a good way to do it; I'm not familiar with usingAtomicU64.