Fix evaluation order

Unleash · Dec 17, 2024 · 9d66bfd · 9d66bfd
1 parent a40c0a7
commit 9d66bfd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/server/src/http/feature_refresher.rs b/server/src/http/feature_refresher.rs
@@ -126,7 +126,7 @@ impl FeatureRefresher {
             persistence,
             strict: config.strict,
             streaming: config.streaming,
-            app_name: config.app_name.into(),
+            app_name: config.app_name,
         }
     }
 

diff --git a/server/tests/streaming_test.rs b/server/tests/streaming_test.rs
@@ -93,7 +93,7 @@ mod streaming_test {
 
         let mut stream = es_client.stream();
 
-        if let Err(_) = tokio::time::timeout(std::time::Duration::from_secs(2), async {
+        if tokio::time::timeout(std::time::Duration::from_secs(2), async {
             loop {
                 if let Some(Ok(event)) = stream.next().await {
                     match event {
@@ -115,6 +115,7 @@ mod streaming_test {
             }
         })
         .await
+        .is_err()
         {
             // If the test times out, kill the app process and fail the test
             edge.kill().expect("Failed to kill the app process");
@@ -127,7 +128,7 @@ mod streaming_test {
             features_from_disk("../examples/hostedexample.json"),
         );
 
-        if let Err(_) = tokio::time::timeout(std::time::Duration::from_secs(2), async {
+        if tokio::time::timeout(std::time::Duration::from_secs(2), async {
             loop {
                 if let Some(Ok(event)) = stream.next().await {
                     match event {
@@ -150,6 +151,7 @@ mod streaming_test {
             }
         })
         .await
+        .is_err()
         {
             // If the test times out, kill the app process and fail the test
             edge.kill().expect("Failed to kill the app process");