feat: add multiple env variables for configuring Redis #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
reviewed
Jun 5, 2023
…-configure-redis-with-multiple-env-variables
chriswk
force-pushed
the
200-id-like-to-be-able-to-configure-redis-with-multiple-env-variables
branch
from
a053a11 to
6392c92
Compare
chriswk
deleted the
200-id-like-to-be-able-to-configure-redis-with-multiple-env-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #199 and #200 we discussed that there are instances of Redis where configuring it with a single REDIS_URL variable doesn't make sense. This PR keeps compatibility with previous REDIS_URL configuration, but allows you to use REDIS_HOST, REDIS_USER, REDIS_PASSWORD, REDIS_PORT, REDIS_SCHEME and REDIS_SECURE (overrides scheme and sets it to rediss) to configure Redis as well.
Combinations like REDIS_URL and REDIS_USER and REDIS_PASSWORD is supported. If connecting to REDIS v5 with password you must set the REDIS_USER variable to
default