Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Added version header to client register response #372

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jan 5, 2024

Related to Unleash/unleash#5774 - This adds an X-Edge-Version header to Edge's responses to /api/client/register.
This will allow Edge to compare the version header with the known version where we added /api/client/metrics/bulk to decide where to post metrics.

@chriswk chriswk self-assigned this Jan 5, 2024
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk merged commit 5a3db0e into main Jan 5, 2024
11 checks passed
@chriswk chriswk deleted the task/addVersionHeaderToClientRegisterResponse branch January 5, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants