Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added client authenticated bulk metrics #373

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jan 8, 2024

So, reflecting what we're doing here: Unleash/unleash#5779 this PR adds a client token authenticated endpoint for posting bulk metrics. We also filter the metrics by the environment the token used to POST metrics has access to.

@@ -82,6 +82,28 @@ pub struct EdgeToken {
pub status: TokenValidationStatus,
}

impl Debug for EdgeToken {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayyyy!

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM

@chriswk chriswk merged commit 1edda8c into main Jan 10, 2024
9 checks passed
@chriswk chriswk deleted the task/addClientMetricsBulkEndpoint branch January 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants