Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:add basic streaming tests #600

Merged
merged 16 commits into from
Dec 16, 2024
Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Dec 12, 2024

Adds a happy-path e2e test for streaming from an upstream server via edge to a client.

Or at least, it does it conceptually. We've changed how the broadcaster is set up, so it actually breaks the functionality for now.

We should set it up so that we test actual Edge and not a mock impl, I think.

Copy link

github-actions bot commented Dec 12, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LGTM :)

@thomasheartman thomasheartman enabled auto-merge (squash) December 16, 2024 13:36
@thomasheartman thomasheartman merged commit 6fa82a9 into main Dec 16, 2024
9 checks passed
@thomasheartman thomasheartman deleted the 1-3180/basic-tests-for-streaming branch December 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants