Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit testing #38

Merged
merged 16 commits into from
Nov 19, 2024
Merged

Update unit testing #38

merged 16 commits into from
Nov 19, 2024

Conversation

apulsipher
Copy link
Contributor

@apulsipher apulsipher commented Nov 13, 2024

Strengthens unit testing:

  • Adds tests to test-sir.R to monitor:
    • Model initialization
    • Model output with and without queuing
    • Model run speed with and without queuing
  • Adds tests to test-lfmcmc.R to monitor:
    • Model initialization
    • Adding simulation, summary, proposal, kernel functions
    • Using factory proposal and kernel functions
    • Missing/optional parameters
  • Created test-sirconn.R, test-sird.R, test-sis.R, test-seir.R with checks for:
    • Model initialization
    • Model runs
    • Model output
  • Created test-tool.R with checks for:
    • Tool initialization
    • Tool helpers (print, getters/setters)
    • Adding/removing tools

@apulsipher apulsipher linked an issue Nov 13, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.37%. Comparing base (e2797fa) to head (2bf7375).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #38       +/-   ##
===========================================
+ Coverage   19.18%   34.37%   +15.18%     
===========================================
  Files          34       36        +2     
  Lines        1777     1882      +105     
===========================================
+ Hits          341      647      +306     
+ Misses       1436     1235      -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@apulsipher apulsipher requested a review from gvegayon November 13, 2024 18:12
@apulsipher
Copy link
Contributor Author

@gvegayon We should add tests for other files (e.g., other model types, generic model methods, etc), but I think it would be better tackled as separate issues. If you want me to do that here, let me know. Otherwise, I'll create issues for the different areas that need unit testing.

@apulsipher apulsipher removed the request for review from gvegayon November 13, 2024 22:47
@apulsipher apulsipher requested a review from gvegayon November 14, 2024 19:36
@apulsipher
Copy link
Contributor Author

@gvegayon I've added a few more test files, but I think this is a good place to stop for this PR. We will add more tests down the line, but we should merge these ones.

@gvegayon gvegayon merged commit ad6aca2 into main Nov 19, 2024
15 checks passed
@gvegayon gvegayon deleted the 33-improve-automated-testing branch November 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve automated testing
2 participants