Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queuing_off() should give warning if the model doesn't have a queue #54

Conversation

apulsipher
Copy link
Contributor

@apulsipher apulsipher commented Nov 27, 2024

This pull request adds a warning to the queuing_off() function for ModelSIRCONN and ModelSEIRCONN classes, because they don't have a queue. This behavior mirrors the behavior of queuing_on() for these model classes.

Additionally, this pull request updates the test-sirconn.R file to cover the expected warnings

@apulsipher apulsipher linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.24%. Comparing base (70f48d5) to head (52ff96f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/model-methods.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   36.21%   36.24%   +0.02%     
==========================================
  Files          36       36              
  Lines        1977     1981       +4     
==========================================
+ Hits          716      718       +2     
- Misses       1261     1263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apulsipher apulsipher requested a review from gvegayon November 27, 2024 15:04
…g_off-should-give-warning-if-the-model-doesnt-have-a-queue
@gvegayon
Copy link
Member

Thanks! Please squash and merge after resolving the conflicts, @apulsipher.

@apulsipher apulsipher merged commit 6c6568d into main Dec 10, 2024
14 checks passed
@apulsipher apulsipher deleted the 40-queuing_off-should-give-warning-if-the-model-doesnt-have-a-queue branch December 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queuing_off() should give warning if the model doesn't have a queue
2 participants