Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_hist_total #18

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

IsaccBarker
Copy link
Collaborator

@IsaccBarker IsaccBarker commented Jun 24, 2024

Fixes #15.


Added database tests by way of running a SEIR model and checking the lengths of the returned Numpy arrays dates, states, and counts to make sure they are of the correct length.


We expose geting the database from models with the getDb function.

We expose getting historical totals from databases with the getHistTotal function, which returns a dictionary of dates, states, and data (counts).

We expose getting the name of a model with the getName function.


Added a graph to the example in the qmd file. This pulls a generated graph from the README_files directory.

We expose geting the database from models with the `getDb` function.

We expose getting historical totals from databases with the
`getHistTotal` function, which returns a dictionary of dates, states,
and data (counts).

We expose getting the name of a model with the `getName` function.
Added database tests by way of running a SEIR model and checking the
lengths of the returned Numpy arrays `dates`, `states`, and `counts` to
make sure they are of the correct length.
@IsaccBarker
Copy link
Collaborator Author

IsaccBarker commented Jun 24, 2024

For reference, a generated graph. I made the y-axis logarithmic because I felt it visualized things better, but if this is unacceptable let me know. Also, the y-axis is labeled count. I assume there's a better label, but I'm unsure as to what it might be.
image

@IsaccBarker IsaccBarker requested a review from gvegayon June 24, 2024 20:15
@IsaccBarker IsaccBarker self-assigned this Jun 24, 2024
@IsaccBarker IsaccBarker added enhancement New feature or request development labels Jun 24, 2024
Added a graph to the example in the `qmd` file. This pulls a generated
graph from the `README_files` directory.
@gvegayon
Copy link
Member

Awesome job! Notice there's a lot of files that should not be included, namely, all the HTML stuff it is only used for pre-view the HTML version of the README.md file.

@gvegayon
Copy link
Member

For reference, a generated graph. I made the y-axis logarithmic because I felt it visualized things better, but if this is unacceptable let me know. Also, the y-axis is labeled count. I assume there's a better label, but I'm unsure as to what it might be. image

Looks great! I would keep the "regular scale" and perhaps remove the susceptible cases only.

@IsaccBarker
Copy link
Collaborator Author

Awesome job! Notice there's a lot of files that should not be included, namely, all the HTML stuff it is only used for pre-view the HTML version of the README.md file.

Sorry about that; I generated an HTML report and must have forgotten to remove that data. Will remove.

@IsaccBarker
Copy link
Collaborator Author

Graph sample
image

@gvegayon
Copy link
Member

The Codacity statement seems to be a common issue: fossasia/query-server#332.

README.md Outdated Show resolved Hide resolved
@gvegayon gvegayon merged commit 97e8b11 into UofUEpiBio:main Jun 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a get_hist_total method wrapper
2 participants