USB Protection Improvement and ExamMode Fix #111

devdl11 · 2021-12-27T10:25:58Z

Some little improvements preparing the release

…BLING THE PROTECTION** ⚠⚠ in order to fix epsilon_ flash (very dangerous thing !!)

…-dev-usbfix

github-actions · 2022-01-29T20:24:08Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	809936 bytes	434244 bytes	226880 bytes	2304 bytes	229184 bytes	1246484 bytes
Head	811592 bytes	433884 bytes	227024 bytes	2304 bytes	229328 bytes	1247780 bytes
	+1656 bytes	-360 bytes	+144 bytes	+0 bytes	+144 bytes	+1296 bytes
	+0.2 %	-0.1 %	+0.1 %	+0.0 %	+0.1 %	+0.1 %

Yaya-Cout · 2022-02-02T14:13:48Z

apps/settings/sub_menu/exam_mode_controller.cpp

+    #if ION_SIMULATOR_FILES
+    mode = GlobalPreferences::ExamMode::Off;
+    #else


I think these lines should be removed, because this pull request is marked as ready for review

I don't know because it add the possibility to disable the exam mode in the simulator without rebooting

Yes, but it is marked as ready to merge…

Indeed because I think it can be a good idea to add the possibility to disable the exam mode in simulators ^^ The exam mode in simulator doesn't make any sense in the first place because you can always leave the simulator and open others app so I don't see the problem by adding the option

Yes, but if we look #131, it is built as a simulator, but it runs on the calculator…

Yes, I agree with Yaya-Cout

apps/apps_container.cpp

Lauryy06 · 2022-02-02T22:24:50Z

apps/shared/function.h

@@ -78,6 +78,7 @@ class Function : public ExpressionModelHandle {
    }
    bool isActive() const { return m_active; }
    void setActive(bool active) { m_active = active; }
+    void setMyColor(KDColor color) {m_color = color; }


Suggested change

void setMyColor(KDColor color) {m_color = color; }

void setMyColor(KDColor color) { m_color = color; }

In fact, is it possible to give a better name to the function?

setGraphColor ?

Lauryy06 · 2022-02-02T22:28:37Z

ion/src/device/shared/boot/rt0.cpp

@@ -245,7 +245,7 @@ void __attribute__((noinline)) start() {
  Ion::Device::Board::initFPU();

  /* Call static C++ object constructors
-   * The C++ compiler creates an initialization function for each static object.
+   * The C++ compiler creates an initialization function   for each static object.


Suggested change

* The C++ compiler creates an initialization function for each static object.

* The C++ compiler creates an initialization function for each static object.

Lauryy06 · 2022-02-02T22:28:55Z

ion/src/device/shared/usb/dfu_interface.cpp

@@ -78,6 +78,7 @@ void DFUInterface::wholeDataSentCallback(SetupPacket *request, uint8_t *transfer
      // Leave DFU routine: Leave DFU, reset device, jump to application code
      leaveDFUAndReset();
    } else if (m_state == State::dfuDNBUSY) {
+      m_state = State::dfuDNBUSY;


I don't understand this line...

Lauryy06 · 2022-02-02T22:29:54Z

ion/src/device/shared/usb/dfu_interface.cpp

@@ -188,7 +189,7 @@ void DFUInterface::changeAddressPointerIfNeeded() {

 void DFUInterface::eraseCommand(uint8_t *transferBuffer, uint16_t transferBufferLength) {
  /* We determine whether the commands asks for a mass erase or which sector to
-   * erase. The erase must be done after the next getStatus request. */
+ * erase. The erase must be done after the next getStatus request. */


I think it has been squashed when merging, but this fork isn't up-to-date, so it isn't corrected in this repo

Lauryy06 · 2022-02-02T22:29:59Z

ion/src/device/shared/usb/dfu_interface.cpp

@@ -152,7 +153,7 @@ bool DFUInterface::processUploadRequest(SetupPacket *request, uint8_t *transferB
  } else {
    /* We decided to never protect Read operation. Else we would have to check
     * here it is not protected before reading. */
-
+    


github-actions · 2022-02-04T17:00:48Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	809936 bytes	434244 bytes	226880 bytes	2304 bytes	229184 bytes	1246484 bytes
Head	811592 bytes	433884 bytes	227024 bytes	2304 bytes	229328 bytes	1247780 bytes
	+1656 bytes	-360 bytes	+144 bytes	+0 bytes	+144 bytes	+1296 bytes
	+0.2 %	-0.1 %	+0.1 %	+0.0 %	+0.1 %	+0.1 %

Yaya-Cout

Can you fetch upstream, and test with the trash ?

Yaya-Cout · 2022-02-24T18:20:38Z

apps/settings/sub_menu/exam_mode_controller.cpp

+    // #if ION_SIMULATOR_FILES
+    // mode = GlobalPreferences::ExamMode::Off;
+    // #else
    mode = GlobalPreferences::sharedGlobalPreferences()->examMode();
+    // #endif


I think these comments can be removed.

Yaya-Cout · 2022-04-03T10:57:12Z

ion/src/device/shared/usb/dfu_interface.cpp

@@ -217,7 +216,7 @@ void DFUInterface::eraseMemoryIfNeeded() {
  if (m_erasePage < 0) {
    return;
  }
-
+  


Remove trailing space…

Suggested change

Yaya-Cout · 2022-04-16T09:22:26Z

I think this pull request have to be updated, because #205 remove the USB protection…

devdl11 · 2023-11-04T11:02:42Z

I close this pull request because it's too outdated to be merged, a completed rework needs to be made

devdl11 and others added 21 commits December 4, 2021 12:44

USB Protection correction

aef43bf

Indentation Fix

5c7e4be

Indentation Fix

6f47e94

Indentation Fix

e3740cb

Add osType in platform_info (Upsilon Magic) and ⚠⚠ **DFU COMMAND DISA…

d8dbd1f

…BLING THE PROTECTION** ⚠⚠ in order to fix epsilon_ flash (very dangerous thing !!)

Merge remote-tracking branch 'origin/uspilon-dev-usbfix' into uspilon…

de478a3

…-dev-usbfix

@Yaya-Cout settings suggestion ;-)

2623637

Indentation Correction

762be7b

CLion mistake fix

8c3398d

dfu_interface.h indentation correction

65419f5

dfu_interface.h indentation correction

c425a8c

dfu_interface.h indentation correction

3b5333c

Foundation

726fd3e

Avancement ExamMode

e8d75aa

Mode Examen Terminé, Patch ld nécessaire pour device

fb428ca

Exam Improvement And DFU fix

0293797

Exam Fix

c7b24be

Merge branch 'upsilon-dev-examdev2' into upsilon-merge-upstream

a412f38

Correcting Upstream Merge errors

6b4d21f

LD fix N0110

ef57ed7

LD test Github Fix

473b83b

devdl11 marked this pull request as draft January 9, 2022 17:01

Fix Sequences App Post Exam Mode

674b8af

devdl11 marked this pull request as ready for review January 29, 2022 20:20

Yaya-Cout reviewed Feb 2, 2022

View reviewed changes

apps/apps_container.cpp Show resolved Hide resolved

Lauryy06 reviewed Feb 2, 2022

View reviewed changes

Review

b06f4f8

Yaya-Cout reviewed Apr 3, 2022

View reviewed changes

devdl11 closed this Nov 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

USB Protection Improvement and ExamMode Fix #111

USB Protection Improvement and ExamMode Fix #111

devdl11 commented Dec 27, 2021

github-actions bot commented Jan 29, 2022

Yaya-Cout Feb 2, 2022

devdl11 Feb 2, 2022

Yaya-Cout Feb 2, 2022

devdl11 Feb 2, 2022

Yaya-Cout Feb 2, 2022

Lauryy06 Feb 2, 2022

Lauryy06 Feb 2, 2022

Lauryy06 Feb 2, 2022

devdl11 Feb 4, 2022

Lauryy06 Feb 2, 2022

Lauryy06 Feb 2, 2022

Lauryy06 Feb 2, 2022

Yaya-Cout Feb 3, 2022 •

edited

Loading

Lauryy06 Feb 2, 2022

github-actions bot commented Feb 4, 2022

Yaya-Cout left a comment •

edited

Loading

Yaya-Cout Feb 24, 2022

Yaya-Cout Apr 3, 2022

Yaya-Cout commented Apr 16, 2022

devdl11 commented Nov 4, 2023

	void setMyColor(KDColor color) {m_color = color; }
	void setMyColor(KDColor color) { m_color = color; }

	* The C++ compiler creates an initialization function for each static object.
	* The C++ compiler creates an initialization function for each static object.

USB Protection Improvement and ExamMode Fix #111

USB Protection Improvement and ExamMode Fix #111

Conversation

devdl11 commented Dec 27, 2021

github-actions bot commented Jan 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yaya-Cout Feb 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 4, 2022

Yaya-Cout left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yaya-Cout commented Apr 16, 2022

devdl11 commented Nov 4, 2023

Yaya-Cout Feb 3, 2022 •

edited

Loading

Yaya-Cout left a comment •

edited

Loading