Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CountryCode): add support for Kosovo country code #2029

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Ignigena
Copy link
Contributor

Description

This adds XK as a valid country code to support Kosovo (see #2028)

This is the hard-coded/brute-force method -- it may be worth keeping the existing regex constrained to official assignments and just relax the restrictions to allow for the user-defined set in the standard: AA, QM to QZ, XA to XZ, and ZZ.

Please feel free to decline if the latter solution is preferred.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ardatan ardatan merged commit 0cbde08 into Urigo:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants