Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Workflow so it tests the code on each push/PR to master #108

Closed
wants to merge 8 commits into from
Closed

Added Workflow so it tests the code on each push/PR to master #108

wants to merge 8 commits into from

Conversation

behzodfaiziev
Copy link
Contributor

@behzodfaiziev behzodfaiziev commented Aug 8, 2024

Initial issue:

  • One of my previous commits made the Vexana score to fall to 140 points due to a minor formatting issue :(
    Screenshot from 2024-08-08 04-15-18

Possible solution:

  • in order to resolve the problem, it is required to add 1 space to get 150 points again.
    Screenshot from 2024-08-08 04-21-25

But this issue may be reproduced again and again.

Better solution: (Learnt from @VB10 that there always should be a thoughtful action)

  • in order to improve the overall quality of the Vexana, I decided to completely automatize the: formatting, analyze and test. So I added a workflow which would be triggered on each PR and push to master. Thus it would make sure that any code which is not of high quality would not pass the overall test.

Additional steps to make tests pass

  • added sort_pub_dependencies, so it does not show error of sorting dependencies
    Screenshot from 2024-08-08 04-24-06

  • added void main(){} in network_manager_test.dart because if the test file is empty, the test will automatically fail.
    Screenshot from 2024-08-08 04-22-44

@behzodfaiziev
Copy link
Contributor Author

@VB10 also when someone opens PR, it would automatically trigger the unit_test.yaml action so that you make sure that everything is fine before reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant