Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add maxRetryCount param #114

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bedirhanssaglam
Copy link
Contributor

I noticed that maxRetryCount is not mutable, maybe it could be a useful improvement.

Tests were run before the Pull Request was opened and it was found that the enhancement did not cause any unforeseen problems:

Ekran Resmi 2024-09-03 14 53 33

@VB10 VB10 assigned VB10 and bedirhanssaglam and unassigned VB10 Sep 3, 2024
@VB10
Copy link
Owner

VB10 commented Sep 3, 2024

@bedirhanssaglam when it is attempted more than once, the value is incremented by one. Immutability has a reason. Thank you. I need to check your press release

Copy link
Owner

@VB10 VB10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VB10 VB10 added the bug Something isn't working label Nov 27, 2024
@VB10 VB10 merged commit 61b0064 into VB10:master Nov 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants