Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web initialization #3

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: web initialization #3

merged 1 commit into from
Jul 30, 2024

Conversation

jsgalarraga
Copy link
Member

Description

When launching the app in web, it was stuck not loading because the flutter_bootstrap.js file was not found.

Screenshot 2024-07-30 at 13 33 13

According to the web initialization documentation using the {{flutter_bootstrap_js}} template token is a valid option for initialization. However, apparently that is only true when you flutter build the app, and not when you flutter run it, unless you manually create the flutter_bootstrap.js file to customize the initialization (as we've done in other projects like the IO Crossword).

By using the async-script tag, the issue is solved, and the app works by doing both flutter run and flutter build.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga self-assigned this Jul 30, 2024
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit 0d66dd8 into main Jul 30, 2024
2 of 3 checks passed
@jolexxa jolexxa deleted the fix/web-initialization branch July 30, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants