Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: internationalization & localization #25

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Conversation

jsgalarraga
Copy link
Member

Screen.Recording.2024-07-16.at.16.03.24.mov

@jsgalarraga jsgalarraga requested review from marwfair and jolexxa July 16, 2024 14:04
@jsgalarraga jsgalarraga self-assigned this Jul 16, 2024
@jsgalarraga jsgalarraga added the documentation Improvements or additions to documentation label Jul 16, 2024
astro.config.mjs Outdated Show resolved Hide resolved
Copy link
Collaborator

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Just left a few small comments.

src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
@jsgalarraga jsgalarraga requested a review from marwfair July 17, 2024 09:31
Co-authored-by: Mark Fairless <[email protected]>
@jsgalarraga jsgalarraga requested a review from marwfair July 17, 2024 14:33
Copy link
Member

@jolexxa jolexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsgalarraga this is really solid, thank you so much! nothing technical, just trying to help tweak the wording a bit for clarity.

src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
src/content/docs/internationalization/localization.mdx Outdated Show resolved Hide resolved
@jsgalarraga jsgalarraga merged commit efe070d into main Jul 29, 2024
3 checks passed
@jolexxa jolexxa deleted the feat/localization branch September 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants