PromQL engine update

* Prefer mapped values
VKCOM · Nov 25, 2024 · 0ab75f5 · 0ab75f5
1 parent 83fb499
commit 0ab75f5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/internal/api/handler.go b/internal/api/handler.go
@@ -2847,14 +2847,13 @@ func (c *pointsSelectCols) rowAt(i int) tsSelectRow {
 		row.val[j] = c.val[j][i]
 	}
 	for j := range c.tag {
-		var hasSTag bool
-		if len(c.stag) != 0 {
-			hasSTag = c.stag[j].Pos[i].Start < c.stag[j].Pos[i].End && c.stag[j].Pos[i].End <= len(c.stag[j].Buf)
-		}
-		if hasSTag {
-			row.stag[c.tagIx[j]] = string(c.stag[j].Buf[c.stag[j].Pos[i].Start:c.stag[j].Pos[i].End])
-		} else {
+		if c.tag[j][i] != 0 {
 			row.tag[c.tagIx[j]] = c.tag[j][i]
+		} else if len(c.stag) != 0 {
+			hasSTag := c.stag[j].Pos[i].Start < c.stag[j].Pos[i].End && c.stag[j].Pos[i].End <= len(c.stag[j].Buf)
+			if hasSTag {
+				row.stag[c.tagIx[j]] = string(c.stag[j].Buf[c.stag[j].Pos[i].Start:c.stag[j].Pos[i].End])
+			}
 		}
 	}
 	if c.tagStr.Pos != nil && i < len(c.tagStr.Pos) {

diff --git a/internal/api/sql.go b/internal/api/sql.go
@@ -55,8 +55,13 @@ const (
 
 func (pq *pointsQuery) cacheKey() string {
 	var sb strings.Builder
-	sb.WriteString(";v=")
-	sb.WriteString(fmt.Sprint(pq.version))
+	sb.WriteString("v=")
+	switch pq.version {
+	case Version1:
+		sb.WriteString(Version1)
+	default:
+		sb.WriteString(Version2)
+	}
 	sb.WriteString(";m=")
 	sb.WriteString(fmt.Sprint(pq.metricID))
 	sb.WriteString(";pk=")