Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release APK does not work otherwise #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lib/display.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ Display displayFromJson(Map<String, dynamic> json) => Display(
name: json['name'],
rotation: json['rotation']);

/// for release please check response from invokeMethod
Display displayReleaseFromJson(Map<String, dynamic> json) => Display(
displayId: json['a'],
flag: json['b'],
name: json['d'],
rotation: json['c']);

/// The default Display id, which is the id of the built-in primary display
/// assuming there is one.
const int DEFAULT_DISPLAY = 0;
Expand Down
4 changes: 1 addition & 3 deletions lib/displays_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ class DisplayManager {
List<Display> displays = [];
for (var element in origins) {
final map = jsonDecode(jsonEncode(element));
displays.add(kReleaseMode
? displayReleaseFromJson(map as Map<String, dynamic>)
: displayFromJson(map as Map<String, dynamic>));
displays.add(displayFromJson(map as Map<String, dynamic>));
}
return displays;
}
Expand Down