Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caskのテストをするactionsを統合する #13

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Caskのテストをするactionsを統合する #13

merged 2 commits into from
Nov 20, 2023

Conversation

umi1299
Copy link
Contributor

@umi1299 umi1299 commented Nov 16, 2023

内容

Branch protectionのRequire status checks to pass before mergingの都合上、2つあると設定ができなかったのでCaskのテストをする ci.ymlci-preview.yml を統合しました

関連

#8

その他

改めて、Branch protection ruleを以下のように設定していただきたいです🙇‍♂️

Branches > Branch protection rules

  • Branch name pattern *
    • main
  • Protect matching branches
    • Require a pull request before merging
      • Require approvals: 1
    • Require status checks to pass before merging
      • Require branches to be up to date before merging
    • Status checks that are required.
      • conclusion (GitHub Actions)

Comment on lines -14 to -15
paths:
- Casks/voicevox.rb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require status checks to pass before mergingの都合上すべてのPRで走らせる必要があるので制限を削除しました

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

branch protectionも変更しておきました!!

@Hiroshiba Hiroshiba merged commit cb67f26 into VOICEVOX:main Nov 20, 2023
5 checks passed
@umi1299 umi1299 deleted the merge-test-actions branch November 20, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants