Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voicevox caskにarm64ダウンロード支援を追加 #47

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Aug 4, 2024

内容

voicevox caskにarm64ダウンロード支援を追加します。

関連 Issue

ref #41
#44 を先にマージする必要があります。

その他

voicevox@previewキャスクだけ残りましたね :)

@nix6839 nix6839 force-pushed the voicevox-arm64 branch 2 times, most recently from 30c6127 to c5dded0 Compare August 4, 2024 00:56
@nix6839 nix6839 marked this pull request as draft August 4, 2024 08:22
@Hiroshiba
Copy link
Member

Hiroshiba commented Aug 4, 2024

プルリクエストありがとうございます!!

voicevox@previewキャスクだけ残りましたね :)

すみません! こちらのコメントはどういう意図でしょうか 👀
(previewはarm64対応できてない、とかでしょうか?)

@nix6839 nix6839 marked this pull request as ready for review August 4, 2024 22:19
@nix6839
Copy link
Contributor Author

nix6839 commented Aug 4, 2024

すみません! こちらのコメントはどういう意図でしょうか 👀
(previewはarm64対応できてない、とかでしょうか?)

voicevox-previewにarm64リリースが追加され、Caskファイルを更新するだけで、現在目に見えるarm64関連の作業が終わったので喜びを表現しました 🎉

@Hiroshiba
Copy link
Member

おお、なるほどです!! 🎉

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 8a8560e into VOICEVOX:main Aug 5, 2024
6 checks passed
@nix6839 nix6839 deleted the voicevox-arm64 branch August 5, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants