Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: 不要なファイルをリリースに入れないようにする #53

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 3, 2024

内容

以下のファイルをリリースに含めないようにします。

  • Privacy.md (我々のは"private build"であるため)
  • include/

関連 Issue

スクリーンショット・動画など

その他

ちなみにpykeio/ortでのONNX Runtimeのダウンロード物はこんな感じになっています。内部利用専用であるためreadmeもありません。

tar --list -f ./ortrs-msort_dylib_cu12-v1.19.0-x86_64-pc-windows-msvc.tgz
onnxruntime/lib/onnxruntime.dll
onnxruntime/lib/onnxruntime.lib
onnxruntime/lib/onnxruntime_providers_cuda.dll
onnxruntime/lib/onnxruntime_providers_shared.dll
onnxruntime/lib/onnxruntime_providers_shared.lib
onnxruntime/lib/onnxruntime_providers_tensorrt.dll

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

これ、もしかしたらWindows以外のOSもホワイトリストにした方がいいかもですねぇ。
普通にディレクトリ構造変えてくるとかありそう。(エラーで落ちてほしい)

まあ、copy_strip_binary.shを信じますか・・・!!

@Hiroshiba Hiroshiba merged commit 62a7558 into VOICEVOX:main Sep 3, 2024
2 checks passed
qryxip added a commit to qryxip/onnxruntime-builder that referenced this pull request Sep 4, 2024
Hiroshiba added a commit that referenced this pull request Sep 4, 2024
* add: voicevox_onnxruntimeをビルドできるようにする

* The crate name was renamed

* [skip ci] `inputs.name` → `inputs.target`

Co-authored-by: Hiroshiba <[email protected]>

* fixup! [skip ci] `inputs.name` → `inputs.target`

* [skip ci] `github.event.inputs` → `inputs.version`

Co-authored-by: Hiroshiba <[email protected]>

* fixup! [skip ci] `github.event.inputs` → `inputs.version`

* `DISCORD_WEBHOOK` → `PRODUCTION_DISCORD_WEBHOOK`

Co-authored-by: Hiroshiba <[email protected]>

* fixup! `DISCORD_WEBHOOK` → `PRODUCTION_DISCORD_WEBHOOK`

* Also silence curl's stderr

Co-authored-by: Hiroshiba <[email protected]>

* fixup! Also silence curl's stderr

* ライセンスをVOICEVOXのものに置き換える

* `build-spec-table`を更新

* `git switch`にダミーの`user.name`と`user.email`は不要なはず

* fixup! fixup! [skip ci] `github.event.inputs` → `inputs.version`

* #53 に適応する

* `$ONNXRUNTIME_NAME` → `$TARGET_LIBRARY`

#52 (comment)

---------

Co-authored-by: Hiroshiba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants