forked from nbigaouette/onnxruntime-rs
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support iOS #19
Merged
Hiroshiba
merged 22 commits into
VOICEVOX:master
from
HyodaKazuaki:feature/support-aarch64-apple-ios
Apr 15, 2023
Merged
support iOS #19
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bcd180d
support iOS
HyodaKazuaki 75423fc
change iOS library target to ios-arm64 and ios-arm64_x86_64-simulator
HyodaKazuaki b666249
add compile strategy for only iOS
HyodaKazuaki 0df261b
change output dir
HyodaKazuaki c7e13ee
fix iOS compile process
HyodaKazuaki 2d3f1b5
fix action shell
HyodaKazuaki 86691fc
fix compiling performance and unused github action
HyodaKazuaki 164d9a5
fix output directory
HyodaKazuaki 26619b8
change iOS default strategy to download
HyodaKazuaki 772df58
fix iOS device target
HyodaKazuaki 2935b14
add x86_64-apple-ios target and remove static lib
HyodaKazuaki c30c6f6
remove download strategy for iOS and
HyodaKazuaki adc9201
add x86_64-apple-ios binding
HyodaKazuaki 082ef93
use prebuild instead of compile strategy
HyodaKazuaki facd505
remove unused simulator os
HyodaKazuaki 652a640
remove unused library
HyodaKazuaki 9350cda
remove version prefix
HyodaKazuaki ee0f161
fix for iOS build
HyodaKazuaki 1277c6f
fix for VOICEVOX organization
HyodaKazuaki cc4f328
Merge branch 'VOICEVOX:master' into feature/support-aarch64-apple-ios
HyodaKazuaki c96e34a
update bingings for iOS
HyodaKazuaki 692c1dc
remove iOS deploy version and add note
HyodaKazuaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rustの命名規則だと
Ios
の方がいいんですが、2行上でnbigaouette氏(オリジナルのonnxruntime-rsの作者)がMacOs
と書いちゃっているので統一感のためにここは致し方なし...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
個人的には仕方ないかなと思いました・・・!
本当はMacosが良いんだろうなとも思います。が、まあ直しちゃうとコンフリクトが出てしまうので・・・ 😇