Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux, Macのビルドを直す #5

Merged
merged 3 commits into from
May 2, 2022
Merged

Conversation

Yosshi999
Copy link

#4 でlinuxとmacのビルドが通らなくなっていた(参照:https://github.com/VOICEVOX/voicevox_core/pull/119)

ソースを直すとともに、CIを動作させ再発防止する

@Yosshi999
Copy link
Author

メモ

https://www.jpcert.or.jp/sc-rules/c-dcl09-c.html

注:EINVAL と EIO は C 標準では定義されていないが、大概の処理系では利用可能であり、POSIX には定義されている。

@Yosshi999 Yosshi999 marked this pull request as ready for review April 29, 2022 23:03
@Yosshi999
Copy link
Author

errnoの使用を取り消した。代わりにenumを定義した

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMですー!
コード自体は問題ないですが、ちょっと書式というか、変わってた部分があったので、suggestしておきました。

@@ -2,9 +2,9 @@ name: C/C++ CI

on:
push:
branches: [ '1.10' ]
branches: [ '1.10', '1.11']

This comment was marked as resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、これはupstream側のコード変更なんですね、こちらで不用意に触らない方がいいと思ったので、このsuggestionは取り下げます

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おそらく全体的には大丈夫だと思いました!

一部 typo を発見したので修正よろしくお願いします……!

src/text2mecab/text2mecab.c Outdated Show resolved Hide resolved
src/text2mecab/text2mecab.h Outdated Show resolved Hide resolved
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PickledChair PickledChair merged commit b56a8ed into VOICEVOX:1.11 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants