-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux, Macのビルドを直す #5
Conversation
メモ https://www.jpcert.or.jp/sc-rules/c-dcl09-c.html
|
errnoの使用を取り消した。代わりにenumを定義した |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMですー!
コード自体は問題ないですが、ちょっと書式というか、変わってた部分があったので、suggestしておきました。
@@ -2,9 +2,9 @@ name: C/C++ CI | |||
|
|||
on: | |||
push: | |||
branches: [ '1.10' ] | |||
branches: [ '1.10', '1.11'] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、これはupstream側のコード変更なんですね、こちらで不用意に触らない方がいいと思ったので、このsuggestionは取り下げます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おそらく全体的には大丈夫だと思いました!
一部 typo を発見したので修正よろしくお願いします……!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#4 でlinuxとmacのビルドが通らなくなっていた(参照:https://github.com/VOICEVOX/voicevox_core/pull/119)
ソースを直すとともに、CIを動作させ再発防止する