Merge upstream 0.3.2 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about the exact root cause, but the error messages suggested that there's issues with setuptools/pip. I can confirm we can fix the issue by changing the build-time setuptools requirement to <v60.0. At least v59.8.0 should work. https://github.com/pypa/setuptools/releases/tag/v59.8.0
Workaround the installation issue r9y9#27
Update binary dependencies (hts_engine_API/open_jtalk)
Fixees for Python 3.10
Co-authored-by: Ryuichi Yamamoto <[email protected]>
Co-authored-by: Ryuichi Yamamoto <[email protected]>
Co-authored-by: Ryuichi Yamamoto <[email protected]>
Use oldest-supported-numpy
Remove wheel in requires
ADD: build-backend key to pyproject.toml
Limit maximum Cython version to avoid build break
FIX: Fix compile error when Cython 3.0
ENH: Fix requires numpy version
ENH: add build-system requires cmake
Change lint to dev. Add Cython to dev.
ENH: Remove Cython from install_requires.
Checking cmake is in the system path for windows
|
テストが通ったのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
でpython 3.7用のテストが落ちていたっぽいので、フォーク元のバージョン0.3.2をマージしてみます。
要forwardマージ。
関連 Issue
スクリーンショット・動画など
その他
変更がいっぱいあるように見えますが、すでにこのリポジトリには0.3.0がマージ済みなのですが、以前はforwardマージしていなかったのでその時のコミット分が全部入っている感じです。