Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ボイボ寮のキャラクター一覧の見た目を改善 #170

Merged
merged 4 commits into from
Sep 29, 2023
Merged

ボイボ寮のキャラクター一覧の見た目を改善 #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ea6261
キャラクター画像の下側が切れてる感じをなくす
thiramisu Sep 28, 2023
c9d2114
キャラクターカードの間や水平線との余白を均等にする
thiramisu Sep 28, 2023
ae1a6b1
7期生の上に水平線を追加
thiramisu Sep 28, 2023
29f739b
Apply suggestions from code review
Hiroshiba Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/dormitoryCharacterCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ export default ({
alt={characterInfo.name}
objectFit="contain"
/>
<div className="card-content has-text-centered">
<div
className="card-content has-text-centered"
style={{ borderColor: color }}
>
<h3 className="title is-5">{characterInfo.name}</h3>
</div>
</Link>
Expand Down
11 changes: 11 additions & 0 deletions src/components/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,10 @@ $dropdown-item-active-background-color: $primary;
background-color: white;

&.character-container {
.columns:not(:last-child) {
margin-bottom: -0.75rem; // columnsは下方向のmargin調整がないので、hrの辻褄を合わせに必要
}

.generation-label {
@extend .has-text-centered;
display: flex;
Expand All @@ -495,6 +499,11 @@ $dropdown-item-active-background-color: $primary;
}
}

.jump-anchor-header-padding {
// カード間の余白を均等にする
padding-top: calc(3.25rem + 1rem + 0.75rem); // 元が3.25rem + 1rem、column分が0.75rem
}

.card {
box-shadow: none;
border-style: solid;
Expand All @@ -503,6 +512,7 @@ $dropdown-item-active-background-color: $primary;
}

.character-card {
@extend .pt-3;
cursor: pointer;

.card-image {
Expand All @@ -512,6 +522,7 @@ $dropdown-item-active-background-color: $primary;
.card-content {
@extend .px-0;
@extend .has-text-centered;
border-top: solid 2.5px;
}
}

Expand Down