Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ボイボ寮名前追加と、バージョン履歴に情報がたされないバグの修正 #174

Merged
merged 1 commit into from
Oct 12, 2023
+33 −6
Merged

ボイボ寮名前追加と、バージョン履歴に情報がたされないバグの修正 #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/hooks/useDetailedCharacterInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,11 @@ const _callNameInfos: {
春歌ナナ: "ナナ",
猫使アル: "アル",
猫使ビィ: "ビィ",
中国うさぎ: "うさぎ",
栗田まろん: "まろん",
藍田ノエル: "あいえる",
満別花丸: "花丸",
琴詠ニア: "ニア",
},
白上虎太郎: {
me: ["おれ"],
Expand Down Expand Up @@ -1142,6 +1147,11 @@ const _callNameInfos: {
春歌ナナ: "ナナちゃん",
猫使アル: "アルちゃん",
猫使ビィ: "ビィちゃん",
中国うさぎ: "うさぎちゃん",
栗田まろん: "まろんちゃん/くん",
藍田ノエル: "あいえるちゃん",
満別花丸: "花丸ちゃん",
琴詠ニア: "ニアちゃん",
},
青山龍星: {
me: ["オレ"],
Expand Down Expand Up @@ -1170,6 +1180,11 @@ const _callNameInfos: {
春歌ナナ: "ナナ",
猫使アル: "アル",
猫使ビィ: "ビィ",
中国うさぎ: "うさぎ",
栗田まろん: "まろん",
藍田ノエル: "あいえる",
満別花丸: "花丸",
琴詠ニア: "ニア",
},
冥鳴ひまり: {
me: ["私"],
Expand Down Expand Up @@ -1494,7 +1509,9 @@ const _callNameInfos: {
猫使アル: "アルちゃん",
猫使ビィ: "ビィちゃん",
中国うさぎ: "うさぎちゃん",
栗田まろん: "まろんさん",
栗田まろん: "まろんくん",
藍田ノエル: "あいえるたん",
満別花丸: "花丸ちゃん",
琴詠ニア: "ニアさん",
},
ナースロボ＿タイプＴ: {
Expand Down Expand Up @@ -1587,6 +1604,11 @@ const _callNameInfos: {
春歌ナナ: "春歌さん",
猫使アル: "アルさん",
猫使ビィ: "ビィさん",
中国うさぎ: "うさぎさん",
栗田まろん: "まろんさん",
藍田ノエル: "あいえるさん",
満別花丸: "花丸さん",
琴詠ニア: "ニアさん",
},
麒ヶ島宗麟: {
me: ["私"],
Expand Down Expand Up @@ -1615,6 +1637,11 @@ const _callNameInfos: {
春歌ナナ: "ナナちゃん",
猫使アル: "アルちゃん",
猫使ビィ: "ビィちゃん",
中国うさぎ: "うさぎちゃん",
栗田まろん: "まろんくん",
藍田ノエル: "あいえるちゃん",
満別花丸: "花丸ちゃん",
琴詠ニア: "ニアちゃん",
},
春歌ナナ: {
me: ["ナナ", "わたし"],
Expand Down
10 changes: 5 additions & 5 deletions src/pages/update_history.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ export default () => {
<div className="update-history">
<h1 className="title">変更履歴</h1>
{events.map((e, index) => (
<>
<div key={index}>
<React.Fragment key={`${e.version}-${index}`}>
<div>
Comment on lines -48 to +49
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここをフラグメントにすることでなぜかバージョン情報が表示されないバグが直りました。
ちょっと理由がよくわかってないです。

<h2 className="subtitle is-4">ver {e.version}</h2>
<ul>
{e.descriptions.map((d, index) => (
<li key={index}>{d}</li>
<li key={`${index}`}>{d}</li>
))}
</ul>
{e.contributors.length > 0 && (
Expand All @@ -64,8 +64,8 @@ export default () => {
</>
)}
</div>
{events.length !== index + 1 && <hr />}
</>
{events.length !== index + 1 && <hr key={`hr-${e.version}`} />}
</React.Fragment>
))}
</div>
</div>
Expand Down